]> git.ipfire.org Git - thirdparty/linux.git/commit
ipv4: account for fraggap on the paged allocation path
authorWongi Lee <qw3rtyp0@gmail.com>
Tue, 16 Jun 2026 13:38:29 +0000 (22:38 +0900)
committerJakub Kicinski <kuba@kernel.org>
Sun, 21 Jun 2026 22:24:49 +0000 (15:24 -0700)
commiteca856950f7cb1a221e02b99d758409f2c5cec42
tree818f5d2057362f1c1964d2e8d49bbcb2d4dec2f1
parent54704b32b2abd62dbb63082c89fa35685c34674a
ipv4: account for fraggap on the paged allocation path

In __ip_append_data(), when the paged-allocation branch is taken,
alloclen and pagedlen are computed as

alloclen = fragheaderlen + transhdrlen;
pagedlen = datalen - transhdrlen;

datalen already includes fraggap, but the fraggap bytes carried over
from the previous skb are copied into the new skb's linear area at
offset transhdrlen by the subsequent skb_copy_and_csum_bits(). The
linear area is therefore undersized by fraggap bytes while pagedlen is
overstated by the same amount.

The non-paged branch sets alloclen to fraglen, which already accounts
for fraggap because datalen does. Bring the paged branch in line by
adding fraggap to alloclen and subtracting it from pagedlen.

After this adjustment, copy no longer collapses to -fraggap on the
paged path, so remove the stale comment describing that old arithmetic.

Fixes: 8eb77cc73977 ("ipv4: avoid partial copy for zc")
Signed-off-by: Jungwoo Lee <jwlee2217@gmail.com>
Signed-off-by: Wongi Lee <qw3rtyp0@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/ajFR1eLAIs42TN3g@DESKTOP-19IMU7U.localdomain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/ip_output.c