]> git.ipfire.org Git - thirdparty/linux.git/commit
net: bridge: fix MST static key usage
authorNikolay Aleksandrov <razor@blackwall.org>
Wed, 5 Nov 2025 11:19:19 +0000 (13:19 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 6 Nov 2025 15:32:17 +0000 (07:32 -0800)
commitee87c63f9b2a418f698d79c2991347e31a7d2c27
tree5154c08d1659da8b3070ce628c9eca994c1c911f
parent8dca36978aa80bab9d4da130c211db75c9e00048
net: bridge: fix MST static key usage

As Ido pointed out, the static key usage in MST is buggy and should use
inc/dec instead of enable/disable because we can have multiple bridges
with MST enabled which means a single bridge can disable MST for all.
Use static_branch_inc/dec to avoid that. When destroying a bridge decrement
the key if MST was enabled.

Fixes: ec7328b59176 ("net: bridge: mst: Multiple Spanning Tree (MST) mode")
Reported-by: Ido Schimmel <idosch@nvidia.com>
Closes: https://lore.kernel.org/netdev/20251104120313.1306566-1-razor@blackwall.org/T/#m6888d87658f94ed1725433940f4f4ebb00b5a68b
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20251105111919.1499702-3-razor@blackwall.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/bridge/br_if.c
net/bridge/br_mst.c
net/bridge/br_private.h