]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ice: fix adding AQ LLDP filter for VF
authorLarysa Zaremba <larysa.zaremba@intel.com>
Wed, 3 Dec 2025 13:29:48 +0000 (14:29 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 3 Mar 2026 21:06:04 +0000 (13:06 -0800)
commiteef33aa44935d001747ca97703c08dd6f9031162
tree092d20daf166520c7b71660e1658620fc8cbe8ed
parent1a86a1f7d88996085934139fa4c063b6299a2dd3
ice: fix adding AQ LLDP filter for VF

The referenced commit came from a misunderstanding of the FW LLDP filter
AQ (Admin Queue) command due to the error in the internal documentation.
Contrary to the assumptions in the original commit, VFs can be added and
deleted from this filter without any problems. Introduced dev_info message
proved to be useful, so reverting the whole commit does not make sense.

Without this fix, trusted VFs do not receive LLDP traffic, if there is an
AQ LLDP filter on PF. When trusted VF attempts to add an LLDP multicast
MAC address, the following message can be seen in dmesg on host:

ice 0000:33:00.0: Failed to add Rx LLDP rule on VSI 20 error: -95

Revert checking VSI type when adding LLDP filter through AQ.

Fixes: 4d5a1c4e6d49 ("ice: do not add LLDP-specific filter if not necessary")
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_common.c