]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
selftests: net: fix timeout passed as positional argument to communicate()
authorGal Pressman <gal@nvidia.com>
Tue, 10 Mar 2026 11:58:03 +0000 (13:58 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Mar 2026 02:11:40 +0000 (19:11 -0700)
commitf0bd19316663710de157e85afd62058312aa97e1
tree574c5809165bc5129e0aad42fdccd720a4f363ea
parent82562972b85469e23fb787f78c1dea6ad6b16af4
selftests: net: fix timeout passed as positional argument to communicate()

The cited commit refactored the hardcoded timeout=5 into a parameter,
but dropped the keyword from the communicate() call.
Since Popen.communicate()'s first positional argument is 'input' (not
'timeout'), the timeout value is silently treated as stdin input and the
call never enforces a timeout.

Pass timeout as a keyword argument to restore the intended behavior.

Reviewed-by: Nimrod Oren <noren@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Link: https://patch.msgid.link/20260310115803.2521050-3-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/lib/py/utils.py