]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Fix mkdir_recursive on windows when CWD is root
authorCiaran Woodward <ciaranwoodward@xmos.com>
Wed, 12 Feb 2025 17:57:32 +0000 (17:57 +0000)
committerCiaran Woodward <ciaranwoodward@xmos.com>
Tue, 25 Feb 2025 14:58:15 +0000 (14:58 +0000)
commitf2cc668e2b0c75d8baaf1b754d9a311084508db3
treea49321c844211bcfa8c1a36a232defdbc7fe8306
parent6693696a7dac44f2f80e89d2d0c4bebfb4543b59
Fix mkdir_recursive on windows when CWD is root

On windows, when creating a directory with an absolute path,
mkdir_recursive would start by trying to make 'C:'.

On windows, this has a special meaning, which is "the current
directory on the C drive". So the first thing it tries to do
is create the current directory.

Most of the time, this fails with EEXIST, so the function
continues as expected. However if the current directory is
C:/, trying to create that causes EPERM, which causes the
function to prematurely terminate.

(The same applies for any drive letter.)

This patch resolves this issue, by skipping the drive letter
so that it is never sent to the mkdir call.

Approved-By: Tom Tromey <tom@tromey.com>
gdbsupport/filestuff.cc