]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_dump: check for _beginthreadex() failure in parallel dump
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 7 Jul 2026 15:11:28 +0000 (18:11 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 7 Jul 2026 15:11:47 +0000 (18:11 +0300)
commitf59a592f9b2fe64affdbc63187d2da763df0caf0
tree13c759c96a5d7cac6372d7b8afca830df3c06d69
parent0115650de9374888f2e64d8dae5fbfd06ec45c7e
pg_dump: check for _beginthreadex() failure in parallel dump

ParallelBackupStart() stored _beginthreadex()'s return value as the
worker's thread handle without checking it.  On failure that value is 0,
which would later reach WaitForMultipleObjects() as a null handle, caught
only by an Assert.  The fork() path already calls pg_fatal() when it
fails; do the same for _beginthreadex(), as pgbench does.

Author: Bryan Green <dbryan.green@gmail.com>
Discussion: https://www.postgresql.org/message-id/8c712d76-ecf7-4749-a6d8-dddc01f298ec@gmail.com
Backpatch-through: 14
src/bin/pg_dump/parallel.c