]> git.ipfire.org Git - thirdparty/linux.git/commit
net: emac: Fix NULL pointer dereference in emac_probe
authorRosen Penev <rosenp@gmail.com>
Thu, 18 Jun 2026 02:34:05 +0000 (19:34 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sun, 21 Jun 2026 21:57:51 +0000 (14:57 -0700)
commitf623d38fe6c4e8c40b23f42cc6fe6963fa49997b
tree2eec46e41fe43eccdc7610058cc52919f3b75d6e
parent617fb6fa9c34457ca37e0c1cf6c88d2f12b014a0
net: emac: Fix NULL pointer dereference in emac_probe

Move devm_request_irq() after devm_platform_ioremap_resource() so that
dev->emacp is mapped before the interrupt handler can fire.  An early
interrupt hitting emac_irq() would dereference the NULL dev->emacp and
crash.

Also remove redundant error message. devm_platform_ioremap_resource()
already returns an error message with dev_err_probe().

Fixes: dcc34ef7c834 ("net: ibm: emac: manage emac_irq with devm")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260618023405.415644-1-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/emac/core.c