]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
rtla: Simplify code by caching string lengths
authorWander Lairson Costa <wander@redhat.com>
Mon, 9 Mar 2026 19:46:19 +0000 (16:46 -0300)
committerTomas Glozar <tglozar@redhat.com>
Tue, 10 Mar 2026 09:32:37 +0000 (10:32 +0100)
commitf79720e25b793691dcc46e1f1cd64d01578075c2
tree860ad028bf13cd6707d90f4f5b213a782281c4e5
parenta29430c2bc86b00e62f74299b866216390c7e418
rtla: Simplify code by caching string lengths

Simplify trace_event_save_hist() and set_comm_cgroup() by computing
string lengths once and storing them in local variables, rather than
calling strlen() multiple times on the same unchanged strings. This
makes the code clearer by eliminating redundant function calls and
improving readability.

In trace_event_save_hist(), the write loop previously called strlen()
on the hist buffer twice per iteration for both the size calculation
and loop condition. Store the length in hist_len before entering the
loop. In set_comm_cgroup(), strlen() was called on cgroup_path up to
three times in succession. Store the result in cg_path_len to use in
both the offset calculation and size parameter for subsequent append
operations.

This simplification makes the code easier to read and maintain without
changing program behavior.

Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Link: https://lore.kernel.org/r/20260309195040.1019085-7-wander@redhat.com
Signed-off-by: Tomas Glozar <tglozar@redhat.com>
tools/tracing/rtla/src/trace.c
tools/tracing/rtla/src/utils.c