]> git.ipfire.org Git - thirdparty/linux.git/commit
net: caif: clear client service pointer on teardown
authorZhengchuan Liang <zcliangcn@gmail.com>
Sat, 11 Apr 2026 15:10:26 +0000 (23:10 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 14 Apr 2026 11:21:54 +0000 (13:21 +0200)
commitf7cf8ece8cee3c1ee361991470cdb1eb65ab02e8
treebc09837d2aa45bac11c552851e40e5870538876e
parentfe72340daaf1af588be88056faf98965f39e6032
net: caif: clear client service pointer on teardown

`caif_connect()` can tear down an existing client after remote shutdown by
calling `caif_disconnect_client()` followed by `caif_free_client()`.
`caif_free_client()` releases the service layer referenced by
`adap_layer->dn`, but leaves that pointer stale.

When the socket is later destroyed, `caif_sock_destructor()` calls
`caif_free_client()` again and dereferences the freed service pointer.

Clear the client/service links before releasing the service object so
repeated teardown becomes harmless.

Fixes: 43e369210108 ("caif: Move refcount from service layer to sock and dev.")
Cc: stable@kernel.org
Reported-by: Yifan Wu <yifanwucs@gmail.com>
Reported-by: Juefei Pu <tomapufckgml@gmail.com>
Co-developed-by: Yuan Tan <yuantan098@gmail.com>
Signed-off-by: Yuan Tan <yuantan098@gmail.com>
Suggested-by: Xin Liu <bird@lzu.edu.cn>
Tested-by: Ren Wei <enjou1224z@gmail.com>
Signed-off-by: Zhengchuan Liang <zcliangcn@gmail.com>
Signed-off-by: Ren Wei <n05ec@lzu.edu.cn>
Link: https://patch.msgid.link/9f3d37847c0037568aae698ca23cd47c6691acb0.1775897577.git.zcliangcn@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/caif/cfsrvl.c