]> git.ipfire.org Git - thirdparty/linux.git/commit
eventfs: Fix use-after-free in eventfs_remove_rec()
authorShuangpeng Bai <shuangpeng.kernel@gmail.com>
Thu, 6 Aug 2026 02:27:19 +0000 (22:27 -0400)
committerSteven Rostedt <rostedt@goodmis.org>
Sat, 8 Aug 2026 14:35:33 +0000 (10:35 -0400)
commitfd73b691702170d37d66f4b0278530cea8ed419a
tree6a790a49a4796570a796f2742c5684b268b493b2
parent075b74841bd0065a3bda3440873c747938e69b68
eventfs: Fix use-after-free in eventfs_remove_rec()

eventfs_remove_rec() recursively removes the child at the current loop
position. After the recursive call returns, list_for_each_entry() advances
by reading list.next from the removed child.

If free_ei() drops the final reference, release_ei() reuses the list/rcu
union to queue an SRCU callback. The child may be freed before that read.
The eventfs_mutex serializes list updates, but it does not keep the removed
child alive or prevent the SRCU callback from running.

Use list_for_each_entry_safe() to save the next sibling before recursively
removing the current child.

Cc: stable@vger.kernel.org
Fixes: 43aa6f97c2d0 ("eventfs: Get rid of dentry pointers without refcounts")
Link: https://patch.msgid.link/20260806022719.375354-1-shuangpeng.kernel@gmail.com
Signed-off-by: Shuangpeng Bai <shuangpeng.kernel@gmail.com>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
fs/tracefs/event_inode.c