]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix possible usage of incorrect UPPERREL_SETOP RelOptInfo
authorDavid Rowley <drowley@postgresql.org>
Tue, 4 Nov 2025 22:48:09 +0000 (11:48 +1300)
committerDavid Rowley <drowley@postgresql.org>
Tue, 4 Nov 2025 22:48:09 +0000 (11:48 +1300)
commitfdda78e361f136ec2b8de579b366c1e66bba1199
tree455c10b037bcd94d1f82502b4c6a17bf970398fe
parent0a3d27bfe0fb229253aa95feccd0360530b7edd8
Fix possible usage of incorrect UPPERREL_SETOP RelOptInfo

03d40e4b5 allowed dummy UNION [ALL] children to be removed from the plan
by checking for is_dummy_rel().  That commit neglected to still account
for the relids from the dummy rel so that the correct UPPERREL_SETOP
RelOptInfo could be found and used for adding the Paths to.

Not doing this could result in processing of subsequent UNIONs using the
same RelOptInfo as a previously processed UNION, which could result in
add_path() freeing old Paths that are needed by the previous UNION.

The same fix was independently submitted (2 mins later) by Richard Guo.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Author: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/bee34aec-659c-46f1-9ab7-7bbae0b7616c@gmail.com
src/backend/optimizer/prep/prepunion.c
src/test/regress/expected/union.out