]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
fstab-generator: don't propagate ignored errno
authorFrantisek Sumsal <frantisek@sumsal.cz>
Wed, 5 Apr 2023 18:14:53 +0000 (20:14 +0200)
committerFrantisek Sumsal <frantisek@sumsal.cz>
Thu, 6 Apr 2023 08:26:47 +0000 (10:26 +0200)
With certain fstabs we may propagate ENXIO from the $SYSTEMD_SYSFS_CHECK
check all the way up, making fstab-generator exit with a non-zero EC and
without any helpful message, which is really confusing.

src/fstab-generator/fstab-generator.c

index 69effacaa2c2dcaaa8b3ebb8ba89334c9c100781..cc2c5512dd08f8a1d0cf625812e7753db1ddf946 100644 (file)
@@ -698,10 +698,10 @@ static int parse_fstab(bool initrd) {
                         }
 
                         if (sysfs_check < 0) {
-                                r = getenv_bool_secure("SYSTEMD_SYSFS_CHECK");
-                                if (r < 0 && r != -ENXIO)
-                                        log_debug_errno(r, "Failed to parse $SYSTEMD_SYSFS_CHECK, ignoring: %m");
-                                sysfs_check = r != 0;
+                                k = getenv_bool_secure("SYSTEMD_SYSFS_CHECK");
+                                if (k < 0 && k != -ENXIO)
+                                        log_debug_errno(k, "Failed to parse $SYSTEMD_SYSFS_CHECK, ignoring: %m");
+                                sysfs_check = k != 0;
                         }
 
                         if (sysfs_check && is_device_path(what)) {