]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: gadget: fsl_qe_udc: off by one in setup_received_handle()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 13 Jul 2016 10:14:33 +0000 (13:14 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 20 Nov 2016 01:17:09 +0000 (01:17 +0000)
commit 7442e6db5bdd0dce4615205508301f9b22e502d6 upstream.

The udc->eps[] array has USB_MAX_ENDPOINTS elements so > should be >=.

Fixes: 3948f0e0c999 ('usb: add Freescale QE/CPM USB peripheral controller driver')
Acked-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
[bwh: Backported to 3.16: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/gadget/fsl_qe_udc.c

index ad548333516700401d1707e9b8981eced7bdde54..5d8d4e99c3d452a7a7a0a9832201d008125a4bb4 100644 (file)
@@ -2057,7 +2057,7 @@ static void setup_received_handle(struct qe_udc *udc,
                        struct qe_ep *ep;
 
                        if (wValue != 0 || wLength != 0
-                               || pipe > USB_MAX_ENDPOINTS)
+                               || pipe >= USB_MAX_ENDPOINTS)
                                break;
                        ep = &udc->eps[pipe];