]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolve: expose dns_server_address_valid()
authorYu Watanabe <watanabe.yu+github@gmail.com>
Sun, 26 May 2019 23:35:28 +0000 (08:35 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 16 Jul 2019 21:59:12 +0000 (06:59 +0900)
src/resolve/resolved-def.h
src/resolve/resolved-dns-server.c
src/resolve/resolved-dns-server.h
src/shared/resolve-util.c
src/shared/resolve-util.h

index ea2851b7b1173cebf28eb8e0c6a3ca2b40c1e930..63c24a023f6da2eb56eb7fa64660645fa4faff15 100644 (file)
@@ -22,6 +22,3 @@
 #define SD_RESOLVED_PROTOCOLS_ALL (SD_RESOLVED_MDNS|SD_RESOLVED_LLMNR|SD_RESOLVED_DNS)
 
 #define SD_RESOLVED_QUERY_TIMEOUT_USEC (120 * USEC_PER_SEC)
-
-/* 127.0.0.53 in native endian */
-#define INADDR_DNS_STUB ((in_addr_t) 0x7f000035U)
index 78e5953b3001095e74077678ace923e6e639fcde..cbb3d524b09120584318e366746de481da605581 100644 (file)
@@ -739,19 +739,6 @@ void manager_next_dns_server(Manager *m) {
                 manager_set_dns_server(m, m->dns_servers);
 }
 
-bool dns_server_address_valid(int family, const union in_addr_union *sa) {
-
-        /* Refuses the 0 IP addresses as well as 127.0.0.53 (which is our own DNS stub) */
-
-        if (in_addr_is_null(family, sa))
-                return false;
-
-        if (family == AF_INET && sa->in.s_addr == htobe32(INADDR_DNS_STUB))
-                return false;
-
-        return true;
-}
-
 DnssecMode dns_server_get_dnssec_mode(DnsServer *s) {
         assert(s);
 
index 2c0457243bc0d7cefe9e08841fcf612216ca1d08..54339355aa85367d73ae5c7ef2b14c97dd9c4354 100644 (file)
@@ -132,8 +132,6 @@ DnsServer *manager_set_dns_server(Manager *m, DnsServer *s);
 DnsServer *manager_get_dns_server(Manager *m);
 void manager_next_dns_server(Manager *m);
 
-bool dns_server_address_valid(int family, const union in_addr_union *sa);
-
 DnssecMode dns_server_get_dnssec_mode(DnsServer *s);
 DnsOverTlsMode dns_server_get_dns_over_tls_mode(DnsServer *s);
 
index b433cd24bca9071bf76ed6a07a8ec3df23dde993..3d14410e32a7787c0ea35ffc6a4af23104a98246 100644 (file)
@@ -28,3 +28,16 @@ static const char* const dns_over_tls_mode_table[_DNS_OVER_TLS_MODE_MAX] = {
         [DNS_OVER_TLS_YES] = "yes",
 };
 DEFINE_STRING_TABLE_LOOKUP_WITH_BOOLEAN(dns_over_tls_mode, DnsOverTlsMode, DNS_OVER_TLS_YES);
+
+bool dns_server_address_valid(int family, const union in_addr_union *sa) {
+
+        /* Refuses the 0 IP addresses as well as 127.0.0.53 (which is our own DNS stub) */
+
+        if (in_addr_is_null(family, sa))
+                return false;
+
+        if (family == AF_INET && sa->in.s_addr == htobe32(INADDR_DNS_STUB))
+                return false;
+
+        return true;
+}
index 6ce250846609982b1a8d462f0411967b5ce0cca8..cf097dfaa38466f4252f5b46896501c4f3ea5c94 100644 (file)
@@ -2,8 +2,12 @@
 #pragma once
 
 #include "conf-parser.h"
+#include "in-addr-util.h"
 #include "macro.h"
 
+/* 127.0.0.53 in native endian */
+#define INADDR_DNS_STUB ((in_addr_t) 0x7f000035U)
+
 typedef enum ResolveSupport ResolveSupport;
 typedef enum DnssecMode DnssecMode;
 typedef enum DnsOverTlsMode DnsOverTlsMode;
@@ -61,3 +65,5 @@ DnssecMode dnssec_mode_from_string(const char *s) _pure_;
 
 const char* dns_over_tls_mode_to_string(DnsOverTlsMode p) _const_;
 DnsOverTlsMode dns_over_tls_mode_from_string(const char *s) _pure_;
+
+bool dns_server_address_valid(int family, const union in_addr_union *sa);