]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
return dbuff values, not intermediate variables
authorAlan T. DeKok <aland@freeradius.org>
Tue, 20 Apr 2021 09:51:34 +0000 (05:51 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Tue, 20 Apr 2021 10:13:52 +0000 (06:13 -0400)
src/protocols/radius/encode.c

index 1c8e03a6295d37dfce54b45b64bf2e48d6b99548..305f724aef06e83a69fbe438d33715b1bd72fc1e 100644 (file)
@@ -825,8 +825,7 @@ static ssize_t encode_extended(fr_dbuff_t *dbuff,
                slen = attr_fragment(&work_dbuff, (size_t)vendor_hdr + slen, &hdr, 4, 3, 0);
                if (slen <= 0) return slen;
 
-               fr_dbuff_set(dbuff, &work_dbuff);
-               return slen;
+               return fr_dbuff_set(dbuff, &work_dbuff);
        }
 
        fr_dbuff_in_bytes(&length_field, (uint8_t) fr_dbuff_used(&work_dbuff));
@@ -1100,8 +1099,7 @@ static ssize_t encode_wimax(fr_dbuff_t *dbuff,
                slen = attr_fragment(&work_dbuff, (size_t)slen, &hdr, 9, 8, 7);
                if (slen <= 0) return slen;
 
-               fr_dbuff_set(dbuff, &work_dbuff);
-               return slen;
+               return fr_dbuff_set(dbuff, &work_dbuff);
        }
 
        fr_dbuff_in_bytes(&vsa_length_field, (uint8_t) (fr_dbuff_used(&work_dbuff) - 6));