]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts
authorBreno Leitao <leitao@debian.org>
Tue, 1 Apr 2025 13:47:49 +0000 (06:47 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 May 2025 05:51:01 +0000 (07:51 +0200)
[ Upstream commit 41c721fc093938745d116c3a21326a0ee03bb491 ]

Some machines with tegra_qspi_combined_seq_xfer hardware issues generate
excessive kernel warnings, severely polluting the logs:

    dmesg | grep -i "WARNING:.*tegra_qspi_transfer_one_message" | wc -l
    94451

This patch replaces WARN_ON with WARN_ON_ONCE for timeout conditions to
reduce log spam. The subsequent error message still prints on each
occurrence, providing sufficient information about the failure, while
the stack trace is only needed once for debugging purposes.

Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20250401-tegra-v2-1-126c293ec047@debian.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-tegra210-quad.c

index d1afa4140e8a26600e1c74ffa0fa5e5af5ba5499..2abb54f9a9ba4db673fc7b0ddaba4b42cad85525 100644 (file)
@@ -1117,7 +1117,7 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi,
                                        (&tqspi->xfer_completion,
                                        QSPI_DMA_TIMEOUT);
 
-                       if (WARN_ON(ret == 0)) {
+                       if (WARN_ON_ONCE(ret == 0)) {
                                dev_err(tqspi->dev, "QSPI Transfer failed with timeout: %d\n",
                                        ret);
                                if (tqspi->is_curr_dma_xfer &&