Improve consistency between app_dial and app_queue with regards

to how language is handled between two channels whose native
language is different. Prior to this patch, app_dial would have
the callee inherit the caller's language, and app_queue would not.

After this patch, app_dial no longer has the language inheritance
capability. This seems to make the most sense since it seems more
natural for a person to hear files played back in his/her native
language instead of the language of the person on the far end of
the call. See the CHANGES file for hints on how to keep the
previous behavior of app_dial if desired.

(closes issue #12489)
Reported by: bcnit

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125647 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/CHANGES b/CHANGES
index 178ad082264b8081c81d3b9ca9cd9bb10fbcac6a..875aae5a34c9b99e2469ac7c5903b02ebb5556cc 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -99,6 +99,9 @@ Application Changes
    original CDR; 'R' prevents the new CDR from being reset; 's(var=val)' adds/changes
    the 'var' variable on the original CDR; 'T' forces ast_cdr_end(), ast_cdr_answer(),
    obey the LOCKED flag on cdr's in the chain, and also the ast_cdr_setvar() func.
+ * The Dial() application no longer copies the language used by the caller to the callee's
+   channel. If you desire for the caller's channel's language to be used for file playback
+   to the callee, then the file specified may be prepended with "${CHANNEL(language)}/" .
 
 SIP Changes
 -----------

diff --git a/apps/app_dial.c b/apps/app_dial.c
index 641edc5b3eb1772578559018994574d1f722a096..b7cafd09114bd01db9d46b4794345eab186222d8 100644 (file)
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -1496,8 +1496,6 @@ static int dial_exec_full(struct ast_channel *chan, void *data, struct ast_flags
                S_REPLACE(tc->cid.cid_ani, ast_strdup(chan->cid.cid_ani));
                S_REPLACE(tc->cid.cid_rdnis, ast_strdup(chan->cid.cid_rdnis));
                
-               /* Copy language from incoming to outgoing */
-               ast_string_field_set(tc, language, chan->language);
                ast_string_field_set(tc, accountcode, chan->accountcode);
                tc->cdrflags = chan->cdrflags;
                if (ast_strlen_zero(tc->musicclass))