]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: ov2659: Fix missing 720p register config
authorBenoit Parrot <bparrot@ti.com>
Mon, 30 Sep 2019 13:06:43 +0000 (10:06 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Dec 2019 15:34:51 +0000 (16:34 +0100)
[ Upstream commit 9d669fbfca20e6035ead814e55d9ef1a6b500540 ]

The initial registers sequence is only loaded at probe
time. Afterward only the resolution and format specific
register are modified. Care must be taken to make sure
registers modified by one resolution setting are reverted
back when another resolution is programmed.

This was not done properly for the 720p case.

Signed-off-by: Benoit Parrot <bparrot@ti.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/i2c/ov2659.c

index ca079996c7ceeac1f5c3c9a9b59e4af5f5ec2b68..4b6be3b0fd5283723cac3b2424fdfb5f92acb2b7 100644 (file)
@@ -419,10 +419,14 @@ static struct sensor_register ov2659_720p[] = {
        { REG_TIMING_YINC, 0x11 },
        { REG_TIMING_VERT_FORMAT, 0x80 },
        { REG_TIMING_HORIZ_FORMAT, 0x00 },
+       { 0x370a, 0x12 },
        { 0x3a03, 0xe8 },
        { 0x3a09, 0x6f },
        { 0x3a0b, 0x5d },
        { 0x3a15, 0x9a },
+       { REG_VFIFO_READ_START_H, 0x00 },
+       { REG_VFIFO_READ_START_L, 0x80 },
+       { REG_ISP_CTRL02, 0x00 },
        { REG_NULL, 0x00 },
 };