]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Use variables instead of substitutions
authorcypherpunks <cypherpunks@torproject.org>
Fri, 11 Dec 2015 22:51:17 +0000 (23:51 +0100)
committerNick Mathewson <nickm@torproject.org>
Mon, 14 Dec 2015 18:11:20 +0000 (13:11 -0500)
Using variables removes the ambiguity about when to use variables and
when to use substitutions. Variables always work. Substitutions only
work when Autoconf knows about them which is not always the case.

The variables are also placed between quotes to ensures spaces in the
variables are handled properly.

src/test/include.am

index a24c5bb1b47b2d5b9a3165980e33a62469358785..9577e1e80f0b80196cbcb896b1719f2dc6c13526 100644 (file)
@@ -1,8 +1,8 @@
 AM_TESTS_ENVIRONMENT = \
-       export PYTHON=@PYTHON@; \
-       export SHELL=@SHELL@; \
-       export abs_top_srcdir=@abs_top_srcdir@; \
-       export builddir=@builddir@; \
+       export PYTHON="$(PYTHON)"; \
+       export SHELL="$(SHELL)"; \
+       export abs_top_srcdir="$(abs_top_srcdir)"; \
+       export builddir="$(builddir)"; \
        export TESTING_TOR_BINARY="$(TESTING_TOR_BINARY)";
 
 TESTSCRIPTS = src/test/test_zero_length_keys.sh