bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114)

This code does not appear to be used anywhere in the python code base.
The use was removed in eb81795d7d3a8c898fa89.
(cherry picked from commit b91a3a0d61596cafb1b46c98fab65fee16a8bbbb)

Co-authored-by: Eitan Adler <grimreaper@users.noreply.github.com>

diff --git a/Misc/ACKS b/Misc/ACKS
index dcd0ca77a40b1fc0c11ff1d29ec319c3adfb164e..c564c048f11fa372f4a57d1b5dd7243c7f7e282a 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -18,6 +18,7 @@ David Abrahams
 Marc Abramowitz
 Eldar Abusalimov
 Ron Adam
+Eitan Adler
 Anton Afanasyev
 Ali Afshar
 Nitika Agarwal

diff --git a/Misc/NEWS.d/next/Build/2018-05-25-13-05-51.bpo-33648.bJ4JZH.rst b/Misc/NEWS.d/next/Build/2018-05-25-13-05-51.bpo-33648.bJ4JZH.rst
new file mode 100644 (file)
index 0000000..eaac4eb
--- /dev/null
+++ b/Misc/NEWS.d/next/Build/2018-05-25-13-05-51.bpo-33648.bJ4JZH.rst
@@ -0,0 +1,2 @@
+The --with-c-locale-warning configuration flag has been removed. It has had
+no effect for about a year.

diff --git a/configure b/configure
index 3e52e60f915792cc1a7adf06b5164d87ae110aab..ef948f698e1ea2be5ce0a647b8d4c11a3bff581b 100755 (executable)
--- a/configure
+++ b/configure
@@ -831,7 +831,6 @@ enable_ipv6
 with_doc_strings
 with_pymalloc
 with_c_locale_coercion
-with_c_locale_warning
 with_valgrind
 with_dtrace
 with_libm
@@ -1527,9 +1526,6 @@ Optional Packages:
   --with(out)-c-locale-coercion
                           disable/enable C locale coercion to a UTF-8 based
                           locale
-  --with(out)-c-locale-warning
-                          disable/enable locale compatibility warning in the C
-                          locale
   --with-valgrind         Enable Valgrind support
   --with(out)-dtrace      disable/enable DTrace support
   --with-libm=STRING      math library
@@ -11128,29 +11124,6 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $with_c_locale_coercion" >&5
 $as_echo "$with_c_locale_coercion" >&6; }
 
-# Check for --with-c-locale-warning
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for --with-c-locale-warning" >&5
-$as_echo_n "checking for --with-c-locale-warning... " >&6; }
-
-# Check whether --with-c-locale-warning was given.
-if test "${with_c_locale_warning+set}" = set; then :
-  withval=$with_c_locale_warning;
-fi
-
-
-if test -z "$with_c_locale_warning"
-then
-    with_c_locale_warning="yes"
-fi
-if test "$with_c_locale_warning" != "no"
-then
-
-$as_echo "#define PY_WARN_ON_C_LOCALE 1" >>confdefs.h
-
-fi
-{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $with_c_locale_warning" >&5
-$as_echo "$with_c_locale_warning" >&6; }
-
 # Check for Valgrind support
 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for --with-valgrind" >&5
 $as_echo_n "checking for --with-valgrind... " >&6; }

diff --git a/configure.ac b/configure.ac
index 3885786aab2ae36326e2adac665126fd4a47ab4f..ecb633b763cd1c90f8594b9c3de1a72d8126b8f1 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -3385,23 +3385,6 @@ then
 fi
 AC_MSG_RESULT($with_c_locale_coercion)
 
-# Check for --with-c-locale-warning
-AC_MSG_CHECKING(for --with-c-locale-warning)
-AC_ARG_WITH(c-locale-warning,
-            AS_HELP_STRING([--with(out)-c-locale-warning],
-              [disable/enable locale compatibility warning in the C locale]))
-
-if test -z "$with_c_locale_warning"
-then
-    with_c_locale_warning="yes"
-fi
-if test "$with_c_locale_warning" != "no"
-then
-    AC_DEFINE(PY_WARN_ON_C_LOCALE, 1,
-      [Define to emit a locale compatibility warning in the C locale])
-fi
-AC_MSG_RESULT($with_c_locale_warning)
-
 # Check for Valgrind support
 AC_MSG_CHECKING([for --with-valgrind])
 AC_ARG_WITH([valgrind],

diff --git a/pyconfig.h.in b/pyconfig.h.in
index e561a7c07cca7896f35faaa1f2dc9d07823ca42a..d7d3b0c1532ac18356e4ea9db670f47c4cff5ccc 100644 (file)
--- a/pyconfig.h.in
+++ b/pyconfig.h.in
@@ -1324,9 +1324,6 @@
 /* Cipher suite string for PY_SSL_DEFAULT_CIPHERS=0 */
 #undef PY_SSL_DEFAULT_CIPHER_STRING
 
-/* Define to emit a locale compatibility warning in the C locale */
-#undef PY_WARN_ON_C_LOCALE
-
 /* Define if you want to build an interpreter with many run-time checks. */
 #undef Py_DEBUG