auth: userdb - Stop calling USERDB_RESULT_OK after template expansion failure

Call only USERDB_RESULT_INTERNAL_FAILURE. This was broken by
0f5dc4da3982053036be65190e44bf28a67b1ca2.

diff --git a/src/auth/userdb-passwd.c b/src/auth/userdb-passwd.c
index 3c9910279dee4d894a1b1873a3608959256bde81..a16cb3b38ad16f36c56294c4762baf7249c7da3a 100644 (file)
--- a/src/auth/userdb-passwd.c
+++ b/src/auth/userdb-passwd.c
@@ -118,6 +118,7 @@ static void passwd_lookup(struct auth_request *auth_request,
                e_error(authdb_event(auth_request),
                        "Failed to expand template: %s", error);
                callback(USERDB_RESULT_INTERNAL_FAILURE, auth_request);
+               return;
        }
 
        callback(USERDB_RESULT_OK, auth_request);

diff --git a/src/auth/userdb-static.c b/src/auth/userdb-static.c
index bed0f586167ec6c94f6a36198a8aef70c5103af7..4263262794a0610655b57b1d2d6286343796f28d 100644 (file)
--- a/src/auth/userdb-static.c
+++ b/src/auth/userdb-static.c
@@ -33,6 +33,7 @@ static void static_lookup_real(struct auth_request *auth_request,
                e_error(authdb_event(auth_request),
                        "Failed to expand template: %s", error);
                callback(USERDB_RESULT_INTERNAL_FAILURE, auth_request);
+               return;
        }
        callback(USERDB_RESULT_OK, auth_request);
 }