Avoid needlessly recompilation of library objection files

Fixing the problem of parallel builds sometimes not creating the library
subdirectories caused library object files to get constantly recompiled.
Fix this by remaping how the Makefile subdirectories decide to create
the subdirectories.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

diff --git a/lib/ChangeLog b/lib/ChangeLog
index 3e6272802dc5122650652181d58fb92434204dae..5604f965f40726965b94a4fab16d3f8a6d896866 100644 (file)
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,3 +1,10 @@
+2005-12-29  Theodore Ts'o  <tytso@mit.edu>
+
+       * Makefile.bsd-lib, Makefile.checker, Makefile.darwin-lib,
+               Makefile.elf-lib, Makefile.library, Makefile.profile,
+               Makefile.solaris-lib: Revamp subdirs target so to avoid
+               needless recompilation of library object files.
+
 2005-12-10  Theodore Ts'o  <tytso@mit.edu>
 
        * Makefile.elf-lib, Makefile.solaris-lib: Add $(LDFLAGS) to the

diff --git a/lib/Makefile.bsd-lib b/lib/Makefile.bsd-lib
index d11301fc557279878955a3220f7bb9937a0c839b..e49dd7af7200e0ef058e74db6f2a846aad2b83df 100644 (file)
--- a/lib/Makefile.bsd-lib
+++ b/lib/Makefile.bsd-lib
@@ -13,9 +13,8 @@
 all:: pic image
 
 subdirs:: pic
-
-pic:
-       mkdir pic
+       @echo " MKDIR pic"
+       @mkdir -p pic
 
 BSD_LIB = $(BSDLIB_IMAGE).so.$(BSDLIB_VERSION)
 BSDLIB_PIC_FLAG = -fpic

diff --git a/lib/Makefile.checker b/lib/Makefile.checker
index 372c08890d81607f9da03f8ef5725fbadda727fa..304fc558f06e26147558044911af014fbc4046d0 100644 (file)
--- a/lib/Makefile.checker
+++ b/lib/Makefile.checker
@@ -1,10 +1,8 @@
 all:: checker $(LIBRARY)_chk.a
 
-subdirs:: checker
-
-checker:
-       @echo " MKDIR $@"
-       @mkdir checker
+subdirs:: Makefile
+       @echo " MKDIR checker"
+       @mkdir -p checker
 
 clean::
        $(RM) -rf checker

diff --git a/lib/Makefile.darwin-lib b/lib/Makefile.darwin-lib
index 7ab584fbaffe8a66d77ccdb22c045cfe78afbf0f..c414a911b9e0d7a3000bde494103e8b2b9a4539d 100644 (file)
--- a/lib/Makefile.darwin-lib
+++ b/lib/Makefile.darwin-lib
@@ -12,10 +12,9 @@
 
 all:: pic image
 
-subdirs:: pic
-
-pic:
-       mkdir pic
+subdirs:: Makefile
+       @echo " MKDIR pic"
+       @mkdir -p pic
 
 BSD_LIB = $(BSDLIB_IMAGE).$(BSDLIB_VERSION).dylib
 BSDLIB_PIC_FLAG = -fPIC

diff --git a/lib/Makefile.elf-lib b/lib/Makefile.elf-lib
index 97d9a70e2e5e3ac244dcbc1be8b46e668604aaaa..8819cedabf37f132e0288e71f39312dea8956d66 100644 (file)
--- a/lib/Makefile.elf-lib
+++ b/lib/Makefile.elf-lib
@@ -11,13 +11,11 @@
 # ELF_INSTALL_DIR = $(SHLIBDIR)
 # ELF_OTHER_LIBS = -lc
 
-all:: elfshared image
+all:: image
 
-subdirs:: elfshared
-
-elfshared:
+subdirs:: Makefile
        @echo " MKDIR elfshared"
-       @mkdir elfshared
+       @mkdir -p elfshared
 
 ELF_LIB = $(ELF_IMAGE).so.$(ELF_VERSION)
 ELF_SONAME = $(ELF_IMAGE).so.$(ELF_SO_VERSION)

diff --git a/lib/Makefile.library b/lib/Makefile.library
index 5cff608dc8a336f5efc0bc3e7403efd875a49e8a..92001a7aece998b42afbe9b192a17b70833c1b8d 100644 (file)
--- a/lib/Makefile.library
+++ b/lib/Makefile.library
@@ -4,7 +4,11 @@ install-shlibs::
 
 uninstall-shlibs::
 
-subdirs::
+subdirs:: Makefile
+       @touch subdirs
+
+clean::
+       @$(RM) -f subdirs
 
 $(LIBRARY).a: $(OBJS)
        @echo " GEN_LIB $@"

diff --git a/lib/Makefile.profile b/lib/Makefile.profile
index 44b5704c7bf533dd9f489fb5e56de263a1f07d28..ad0f1df004de2767e7feca6bc2102af445595601 100644 (file)
--- a/lib/Makefile.profile
+++ b/lib/Makefile.profile
@@ -1,10 +1,8 @@
 all:: profiled $(LIBRARY)_p.a
 
-subdirs:: profiled
-
-profiled:
+subdirs:: Makefile
        @echo " MKDIR $@"
-       @mkdir profiled
+       @mkdir -p profiled
 
 clean::
        $(RM) -rf profiled

diff --git a/lib/Makefile.solaris-lib b/lib/Makefile.solaris-lib
index b75c20e1778f8a246fc2773c784f0be2f6f796b4..4bb3f6d8108d41d14b5ee536979e219e37eac09f 100644 (file)
--- a/lib/Makefile.solaris-lib
+++ b/lib/Makefile.solaris-lib
@@ -13,10 +13,9 @@
 
 all:: elfshared image
 
-subdirs:: elfshared
-
-elfshared:
-       mkdir elfshared
+subdirs:: Makefile
+       @echo " MKDIR elfshared"
+       @mkdir -p elfshared
 
 ELF_LIB = $(ELF_IMAGE).so.$(ELF_VERSION)
 ELF_SONAME = $(ELF_IMAGE).so.$(ELF_SO_VERSION)