Document that --vex-guest-chase=not ought to be used when doing IR injection.

Fixes https://bugs.kde.org/show_bug.cgi?id=506453

diff --git a/NEWS b/NEWS
index bdf175eac89de5c94dc2730d30644d916a5c8ccb..7335f05b330b93a7eb74d2b578a6e6710b32c3a6 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -987,6 +987,7 @@ are not entered into bugzilla tend to get forgotten about or ignored.
 451843  valgrind fails to start on a FreeBSD system which enforces W^X
 495483  Control building documentation via BUILD_DOCS
 506211  Constant folding improvements
+506453  Unexpected behaviour with IR injection and vex-guest-chase=yes
 509157  riscv64: Shift instructions can behave wrong
 
 To see details of a given bug, visit

diff --git a/VEX/priv/ir_inject.c b/VEX/priv/ir_inject.c
index 04228538f12bc67b0553fb04af1e5a6e4bff4bc3..b447f6e946f2563199dc5dbbecd60a8be4100ebf 100644 (file)
--- a/VEX/priv/ir_inject.c
+++ b/VEX/priv/ir_inject.c
@@ -27,6 +27,10 @@
    The GNU General Public License is contained in the file COPYING.
 */
 
+/* !!! When running valgrind on applications that use IR injection
+   !!! --vex-guest-chase=no should be given on the command line. This
+   !!! avoids that vex_inject_ir is called speculatively.
+*/
 #include "libvex_basictypes.h"
 #include "libvex_ir.h"
 #include "libvex.h"

diff --git a/memcheck/tests/vbit-test/vbit-test-sec.vgtest b/memcheck/tests/vbit-test/vbit-test-sec.vgtest
index 2d3c9389da89ab4267bdd94f0bda26a0a57d7fd8..8d84e7e90b58ac1ff1b65b8a06da7fb35f582163 100644 (file)
--- a/memcheck/tests/vbit-test/vbit-test-sec.vgtest
+++ b/memcheck/tests/vbit-test/vbit-test-sec.vgtest
@@ -1,3 +1,3 @@
 prog: vbit-test-sec
 prereq: test -x vbit-test-sec
-vgopts: -q --expensive-definedness-checks=yes
+vgopts: -q --expensive-definedness-checks=yes --vex-guest-chase=no

diff --git a/memcheck/tests/vbit-test/vbit-test.vgtest b/memcheck/tests/vbit-test/vbit-test.vgtest
index a05890566b19589aa464b2d32de74ff7a59e8a0c..198c62351cc9f8d4e2740e8a5e3b09ec732614a0 100644 (file)
--- a/memcheck/tests/vbit-test/vbit-test.vgtest
+++ b/memcheck/tests/vbit-test/vbit-test.vgtest
@@ -1,2 +1,2 @@
 prog: vbit-test
-vgopts: -q --expensive-definedness-checks=yes
+vgopts: -q --expensive-definedness-checks=yes --vex-guest-chase=no