Don't use clean_pool with login processes.

The previous fix for clean_pool perhaps might have fixed all the bugs
related to it, but since it only produces extra work with no real benefit,
just don't use it. The original idea behind using it was flawed.

--HG--
branch : HEAD

diff --git a/src/login-common/main.c b/src/login-common/main.c
index 43c85fcb79cc856918c08a227c288bbc577b0d70..67eb90d60b07f9352d4d1868371eb102457bd0d8 100644 (file)
--- a/src/login-common/main.c
+++ b/src/login-common/main.c
@@ -413,13 +413,6 @@ int main(int argc ATTR_UNUSED, char *argv[], char *envp[])
                fd_debug_verify_leaks(i, 1024);
        }
 #endif
-       /* clear all allocated memory before freeing it. this makes the login
-          processes pretty safe to reuse for new connections since the
-          attacker won't be able to find anything interesting from the
-          memory. */
-       default_pool = system_clean_pool;
-       data_stack_set_clean_after_pop(TRUE);
-
        /* NOTE: we start rooted, so keep the code minimal until
           restrict_access_by_env() is called */
        lib_init();