]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mtd: rawnand: cadence: Fix error check for dma_alloc_coherent() in cadence_nand_init()
authorChen Ni <nichen@iscas.ac.cn>
Mon, 9 Feb 2026 07:56:18 +0000 (15:56 +0800)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 25 Feb 2026 16:48:52 +0000 (17:48 +0100)
Fix wrong variable used for error checking after dma_alloc_coherent()
call. The function checks cdns_ctrl->dma_cdma_desc instead of
cdns_ctrl->cdma_desc, which could lead to incorrect error handling.

Fixes: ec4ba01e894d ("mtd: rawnand: Add new Cadence NAND driver to MTD subsystem")
Cc: stable@vger.kernel.org
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/cadence-nand-controller.c

index 99135ec230105ea62ae96e3378b7d883e3cf6c83..d53b35a8b3cb24b4473f2600026581a7a54afa97 100644 (file)
@@ -3133,7 +3133,7 @@ static int cadence_nand_init(struct cdns_nand_ctrl *cdns_ctrl)
                                                  sizeof(*cdns_ctrl->cdma_desc),
                                                  &cdns_ctrl->dma_cdma_desc,
                                                  GFP_KERNEL);
-       if (!cdns_ctrl->dma_cdma_desc)
+       if (!cdns_ctrl->cdma_desc)
                return -ENOMEM;
 
        cdns_ctrl->buf_size = SZ_16K;