]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.14-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 May 2021 15:52:13 +0000 (17:52 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 May 2021 15:52:13 +0000 (17:52 +0200)
added patches:
fbdev-zero-fill-colormap-in-fbcmap.c.patch

queue-4.14/fbdev-zero-fill-colormap-in-fbcmap.c.patch [new file with mode: 0644]
queue-4.14/series

diff --git a/queue-4.14/fbdev-zero-fill-colormap-in-fbcmap.c.patch b/queue-4.14/fbdev-zero-fill-colormap-in-fbcmap.c.patch
new file mode 100644 (file)
index 0000000..2196dd1
--- /dev/null
@@ -0,0 +1,51 @@
+From 19ab233989d0f7ab1de19a036e247afa4a0a1e9c Mon Sep 17 00:00:00 2001
+From: Phillip Potter <phil@philpotter.co.uk>
+Date: Wed, 31 Mar 2021 23:07:19 +0100
+Subject: fbdev: zero-fill colormap in fbcmap.c
+
+From: Phillip Potter <phil@philpotter.co.uk>
+
+commit 19ab233989d0f7ab1de19a036e247afa4a0a1e9c upstream.
+
+Use kzalloc() rather than kmalloc() for the dynamically allocated parts
+of the colormap in fb_alloc_cmap_gfp, to prevent a leak of random kernel
+data to userspace under certain circumstances.
+
+Fixes a KMSAN-found infoleak bug reported by syzbot at:
+https://syzkaller.appspot.com/bug?id=741578659feabd108ad9e06696f0c1f2e69c4b6e
+
+Reported-by: syzbot+47fa9c9c648b765305b9@syzkaller.appspotmail.com
+Cc: stable <stable@vger.kernel.org>
+Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
+Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
+Link: https://lore.kernel.org/r/20210331220719.1499743-1-phil@philpotter.co.uk
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/video/fbdev/core/fbcmap.c |    8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+--- a/drivers/video/fbdev/core/fbcmap.c
++++ b/drivers/video/fbdev/core/fbcmap.c
+@@ -101,17 +101,17 @@ int fb_alloc_cmap_gfp(struct fb_cmap *cm
+               if (!len)
+                       return 0;
+-              cmap->red = kmalloc(size, flags);
++              cmap->red = kzalloc(size, flags);
+               if (!cmap->red)
+                       goto fail;
+-              cmap->green = kmalloc(size, flags);
++              cmap->green = kzalloc(size, flags);
+               if (!cmap->green)
+                       goto fail;
+-              cmap->blue = kmalloc(size, flags);
++              cmap->blue = kzalloc(size, flags);
+               if (!cmap->blue)
+                       goto fail;
+               if (transp) {
+-                      cmap->transp = kmalloc(size, flags);
++                      cmap->transp = kzalloc(size, flags);
+                       if (!cmap->transp)
+                               goto fail;
+               } else {
index e2fa71024418569490ae4b273b188365ae7b66ad..59c14898619f13f7b6108f106358b78e29d9255e 100644 (file)
@@ -26,3 +26,4 @@ mmc-core-set-read-only-for-sd-cards-with-permanent-write-protect-bit.patch
 cifs-return-correct-error-code-from-smb2_get_enc_key.patch
 btrfs-fix-metadata-extent-leak-after-failure-to-create-subvolume.patch
 intel_th-pci-add-rocket-lake-cpu-support.patch
+fbdev-zero-fill-colormap-in-fbcmap.c.patch