lib-storage: Don't clear errors unnecessarily (and inconsistently).

--HG--
branch : HEAD

diff --git a/src/lib-storage/mail-storage.c b/src/lib-storage/mail-storage.c
index 778f36c6b65f4fc6675cbd7d8da326d7703b5ac5..c59fb3f7bab7c11d7f4cf32507316fcda702678a 100644 (file)
--- a/src/lib-storage/mail-storage.c
+++ b/src/lib-storage/mail-storage.c
@@ -393,8 +393,6 @@ void mail_storage_set_callbacks(struct mail_storage *storage,
 
 int mail_storage_purge(struct mail_storage *storage)
 {
-       mail_storage_clear_error(storage);
-
        return storage->v.purge == NULL ? 0 :
                storage->v.purge(storage);
 }
@@ -473,8 +471,6 @@ int mailbox_open(struct mailbox *box)
 {
        int ret;
 
-       mail_storage_clear_error(box->storage);
-
        if (!mailbox_list_is_valid_existing_name(box->list, box->name)) {
                mail_storage_set_error(box->storage, MAIL_ERROR_PARAMS,
                                       "Invalid mailbox name");
@@ -518,8 +514,6 @@ void mailbox_close(struct mailbox **_box)
 int mailbox_create(struct mailbox *box, const struct mailbox_update *update,
                   bool directory)
 {
-       mail_storage_clear_error(box->storage);
-
        if (!mailbox_list_is_valid_create_name(box->list, box->name)) {
                mail_storage_set_error(box->storage, MAIL_ERROR_PARAMS,
                                       "Invalid mailbox name");
@@ -531,8 +525,6 @@ int mailbox_create(struct mailbox *box, const struct mailbox_update *update,
 
 int mailbox_update(struct mailbox *box, const struct mailbox_update *update)
 {
-       mail_storage_clear_error(box->storage);
-
        return box->v.update(box, update);
 }
 

diff --git a/src/lib-storage/mailbox-list.c b/src/lib-storage/mailbox-list.c
index 4d0c6eef895f4bc1ae554da4a847bc4cfb8447ee..38f64fdcba7a19753dc22a751b4067cf5d37e468 100644 (file)
--- a/src/lib-storage/mailbox-list.c
+++ b/src/lib-storage/mailbox-list.c
@@ -493,8 +493,6 @@ bool mailbox_list_is_valid_create_name(struct mailbox_list *list,
 const char *mailbox_list_get_path(struct mailbox_list *list, const char *name,
                                  enum mailbox_list_path_type type)
 {
-       mailbox_list_clear_error(list);
-
        return list->v.get_path(list, name, type);
 }
 
@@ -526,8 +524,6 @@ int mailbox_list_get_mailbox_name_status(struct mailbox_list *list,
                                         const char *name,
                                         enum mailbox_name_status *status)
 {
-       mailbox_list_clear_error(list);
-
        if (!mailbox_list_is_valid_existing_name(list, name)) {
                *status = MAILBOX_NAME_INVALID;
                return 0;
@@ -553,7 +549,6 @@ mailbox_list_iter_init_multiple(struct mailbox_list *list,
 {
        i_assert(*patterns != NULL);
 
-       mailbox_list_clear_error(list);
        return list->v.iter_init(list, patterns, flags);
 }
 
@@ -720,8 +715,6 @@ int mailbox_list_set_subscribed(struct mailbox_list *list,
        uint8_t guid[MAIL_GUID_128_SIZE];
        unsigned char sha[SHA1_RESULTLEN];
 
-       mailbox_list_clear_error(list);
-
        if (list->v.set_subscribed(list, name, set) < 0)
                return -1;