]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
update-dbus-docs: omit verbose output when in --test mode
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Thu, 27 Aug 2020 18:15:30 +0000 (20:15 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Thu, 27 Aug 2020 19:30:23 +0000 (21:30 +0200)
It makes the ninja output listing very long for no good purpose.

tools/update-dbus-docs.py

index 448206cf957005902597cc06b895a95db9e5c82e..0bbc4aab4573b366d0447f31492defa78c4eb2a0 100755 (executable)
@@ -15,8 +15,6 @@ PARSER = etree.XMLParser(no_network=True,
                          strip_cdata=False,
                          resolve_entities=False)
 
-PRINT_ERRORS = True
-
 class NoCommand(Exception):
     pass
 
@@ -38,7 +36,7 @@ def print_method(declarations, elem, *, prefix, file, is_signal=False):
         argname = arg.get('name')
 
         if argname is None:
-            if PRINT_ERRORS:
+            if opts.print_errors:
                 print(f'method {name}: argument {num+1} has no name', file=sys.stderr)
             argname = 'UNNAMED'
 
@@ -140,7 +138,7 @@ def check_documented(document, declarations, stats):
                 assert False, (klass, item)
 
             if not document_has_elem_with_text(document, elem, item_repr):
-                if PRINT_ERRORS:
+                if opts.print_errors:
                     print(f'{klass} {item} is not documented :(')
                 missing.append((klass, item))
 
@@ -283,7 +281,9 @@ def parse_args():
                    help='only verify that everything is up2date')
     p.add_argument('--build-dir', default='build')
     p.add_argument('pages', nargs='+')
-    return p.parse_args()
+    opts = p.parse_args()
+    opts.print_errors = not opts.test
+    return opts
 
 if __name__ == '__main__':
     opts = parse_args()