]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nfsd: don't set SVC_SOCK_ANONYMOUS when creating nfsd sockets
authorJeff Layton <jlayton@kernel.org>
Fri, 19 Jul 2024 18:55:53 +0000 (14:55 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:20 +0000 (15:34 +0200)
[ Upstream commit 91da337e5d506f2c065d20529d105ca40090e320 ]

When creating nfsd sockets via the netlink interface, we do want to
register with the portmapper. Don't set SVC_SOCK_ANONYMOUS.

Reported-by: Steve Dickson <steved@redhat.com>
Fixes: 16a471177496 ("NFSD: add listener-{set,get} netlink command")
Cc: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfsd/nfsctl.c

index c848ebe5d08f121cff5ffb7b5a64e148194fa960..0f9b4f7b56cd8819c64528a3f20cd3e9357f99b2 100644 (file)
@@ -2053,8 +2053,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff *skb, struct genl_info *info)
                        continue;
                }
 
-               ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa,
-                                             SVC_SOCK_ANONYMOUS,
+               ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa, 0,
                                              get_current_cred());
                /* always save the latest error */
                if (ret < 0)