]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-136744: Remove unnecessary chmod from pydoc.apropos() test. (GH-136746)
authorRussell Keith-Magee <russell@keith-magee.com>
Mon, 22 Sep 2025 14:26:13 +0000 (15:26 +0100)
committerGitHub <noreply@github.com>
Mon, 22 Sep 2025 14:26:13 +0000 (16:26 +0200)
Remove unnecessary chmod from pydoc.apropos() test.

Lib/test/test_pydoc/test_pydoc.py

index 40cdee5c6c3dccffb54e10cca22142c9e72c686e..31f0a1eb2cbf4094d571d82e2f490e5e484f5601 100644 (file)
@@ -11,7 +11,6 @@ import keyword
 import _pickle
 import pkgutil
 import re
-import stat
 import tempfile
 import test.support
 import time
@@ -1303,24 +1302,14 @@ class PydocImportTest(PydocBaseTest):
     @os_helper.skip_unless_working_chmod
     def test_apropos_empty_doc(self):
         pkgdir = os.path.join(TESTFN, 'walkpkg')
-        if support.is_emscripten:
-            # Emscripten's readdir implementation is buggy on directories
-            # with read permission but no execute permission.
-            old_umask = os.umask(0)
-            self.addCleanup(os.umask, old_umask)
         os.mkdir(pkgdir)
         self.addCleanup(rmtree, pkgdir)
         init_path = os.path.join(pkgdir, '__init__.py')
         with open(init_path, 'w') as fobj:
             fobj.write("foo = 1")
-        current_mode = stat.S_IMODE(os.stat(pkgdir).st_mode)
-        try:
-            os.chmod(pkgdir, current_mode & ~stat.S_IEXEC)
-            with self.restrict_walk_packages(path=[TESTFN]), captured_stdout() as stdout:
-                pydoc.apropos('')
-            self.assertIn('walkpkg', stdout.getvalue())
-        finally:
-            os.chmod(pkgdir, current_mode)
+        with self.restrict_walk_packages(path=[TESTFN]), captured_stdout() as stdout:
+            pydoc.apropos('')
+        self.assertIn('walkpkg', stdout.getvalue())
 
     def test_url_search_package_error(self):
         # URL handler search should cope with packages that raise exceptions