ksmbd: prevent out-of-bounds stream writes by validating *pos

commit 0ca6df4f40cf4c32487944aaf48319cb6c25accc upstream.

ksmbd_vfs_stream_write() did not validate whether the write offset
(*pos) was within the bounds of the existing stream data length (v_len).
If *pos was greater than or equal to v_len, this could lead to an
out-of-bounds memory write.

This patch adds a check to ensure *pos is less than v_len before
proceeding. If the condition fails, -EINVAL is returned.

Cc: stable@vger.kernel.org
Signed-off-by: Norbert Szetei <norbert@doyensec.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
index fa5b7e63eb832e20a0b3d2f7a96a54ec2921dac0..f6616d687365a3687c6efb38e765afc7bdc8b016 100644 (file)
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -443,6 +443,13 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos,
                goto out;
        }
 
+       if (v_len <= *pos) {
+               pr_err("stream write position %lld is out of bounds (stream length: %zd)\n",
+                               *pos, v_len);
+               err = -EINVAL;
+               goto out;
+       }
+
        if (v_len < size) {
                wbuf = kvzalloc(size, GFP_KERNEL);
                if (!wbuf) {