]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: airoha: Fix non-standard return value in airoha_ppe_get_wdma_info()
authorWayen.Yan <win847@gmail.com>
Sat, 13 Jun 2026 00:22:31 +0000 (08:22 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 15 Jun 2026 22:44:26 +0000 (15:44 -0700)
airoha_ppe_get_wdma_info() returns -1 when the last path in the
forwarding path stack is not of type DEV_PATH_MTK_WDMA. This is not
a standard kernel error code. Replace it with -EINVAL since the
input path type is invalid from the caller's perspective.

Signed-off-by: Wayen.Yan <win847@gmail.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/6a2ca3d9.ad59c0a6.147df9.2a62@mx.google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/airoha/airoha_ppe.c

index 91bcc55a6ac67e03ee82528fc9b87112c74b5bc7..0d42f82be77af966fb2ed44c6bb496ed6998a809 100644 (file)
@@ -277,7 +277,7 @@ static int airoha_ppe_get_wdma_info(struct net_device *dev, const u8 *addr,
 
        path = &stack.path[stack.num_paths - 1];
        if (path->type != DEV_PATH_MTK_WDMA)
-               return -1;
+               return -EINVAL;
 
        info->idx = path->mtk_wdma.wdma_idx;
        info->bss = path->mtk_wdma.bss;