]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/gt: prefer _PICK_EVEN() over _PICK()
authorJani Nikula <jani.nikula@intel.com>
Wed, 25 Feb 2026 17:57:10 +0000 (19:57 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 4 Mar 2026 11:04:31 +0000 (13:04 +0200)
There's no need to use _PICK() here. Use the simpler one instead.

Reviewed-by: MichaƂ Grzelak <michal.grzelak@intel.com>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patch.msgid.link/f94272fb9e93afa51d9fdb006888b8ebe38580df.1772042022.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/gt/intel_gt_regs.h

index 14d31882e9e77c812d60a0ae8dc6cab64d02476c..3ba9b2206b79812c4bb6ec2f0be7f90cdc08c945 100644 (file)
 #define _RING_FAULT_REG_VCS                    0x4194
 #define _RING_FAULT_REG_BCS                    0x4294
 #define _RING_FAULT_REG_VECS                   0x4394
-#define RING_FAULT_REG(engine)                 _MMIO(_PICK((engine)->class, \
-                                                           _RING_FAULT_REG_RCS, \
-                                                           _RING_FAULT_REG_VCS, \
-                                                           _RING_FAULT_REG_VECS, \
-                                                           _RING_FAULT_REG_BCS))
+#define RING_FAULT_REG(engine)                 _MMIO(_PICK_EVEN((engine)->class, \
+                                                                _RING_FAULT_REG_RCS, \
+                                                                _RING_FAULT_REG_VCS))
 #define   RING_FAULT_VADDR_MASK                        REG_GENMASK(31, 12) /* pre-bdw */
 #define   RING_FAULT_ENGINE_ID_MASK            REG_GENMASK(16, 12) /* bdw+ */
 #define   RING_FAULT_GTTSEL_MASK               REG_BIT(11) /* pre-bdw */