drm/sysfb: corebootdrm: Support panel orientation

Add fields and constants for coreboot framebuffer orientation. Set
corebootdrm's DRM connector state from the values. Not all firmware
provides orientation, so make it optional. Systems without, continue
to use unknown orientation.

v3:
- comment on _HAS_ORIENTATION semantics (Tzung-Bi)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Julius Werner <jwerner@chromium.org>
Acked-by: Tzung-Bi Shih <tzungbi@kernel.org> # coreboot
Link: https://patch.msgid.link/20260217155836.96267-13-tzimmermann@suse.de

diff --git a/drivers/gpu/drm/sysfb/corebootdrm.c b/drivers/gpu/drm/sysfb/corebootdrm.c
index 745318580a5d21f91577cfb697b00704c7002a12..5dc6f3c76f7bd97e5a2d63a7db0ed0489dcb32df 100644 (file)
--- a/drivers/gpu/drm/sysfb/corebootdrm.c
+++ b/drivers/gpu/drm/sysfb/corebootdrm.c
@@ -110,6 +110,26 @@ static phys_addr_t corebootdrm_get_address_fb(struct drm_device *dev, resource_s
        return fb->physical_address;
 }
 
+static enum drm_panel_orientation corebootdrm_get_orientation_fb(struct drm_device *dev,
+                                                                const struct lb_framebuffer *fb)
+{
+       if (!LB_FRAMEBUFFER_HAS_ORIENTATION(fb))
+               return DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
+
+       switch (fb->orientation) {
+       case LB_FRAMEBUFFER_ORIENTATION_NORMAL:
+               return DRM_MODE_PANEL_ORIENTATION_NORMAL;
+       case LB_FRAMEBUFFER_ORIENTATION_BOTTOM_UP:
+               return DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP;
+       case LB_FRAMEBUFFER_ORIENTATION_LEFT_UP:
+               return DRM_MODE_PANEL_ORIENTATION_LEFT_UP;
+       case LB_FRAMEBUFFER_ORIENTATION_RIGHT_UP:
+               return DRM_MODE_PANEL_ORIENTATION_RIGHT_UP;
+       }
+
+       return DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
+}
+
 /*
  * Simple Framebuffer device
  */
@@ -168,7 +188,8 @@ static const struct drm_mode_config_funcs corebootdrm_mode_config_funcs = {
        DRM_SYSFB_MODE_CONFIG_FUNCS,
 };
 
-static int corebootdrm_mode_config_init(struct corebootdrm_device *cdev)
+static int corebootdrm_mode_config_init(struct corebootdrm_device *cdev,
+                                       enum drm_panel_orientation orientation)
 {
        struct drm_sysfb_device *sysfb = &cdev->sysfb;
        struct drm_device *dev = &sysfb->dev;
@@ -234,8 +255,7 @@ static int corebootdrm_mode_config_init(struct corebootdrm_device *cdev)
        if (ret)
                return ret;
        drm_connector_helper_add(connector, &corebootdrm_connector_helper_funcs);
-       drm_connector_set_panel_orientation_with_quirk(connector,
-                                                      DRM_MODE_PANEL_ORIENTATION_UNKNOWN,
+       drm_connector_set_panel_orientation_with_quirk(connector, orientation,
                                                       width, height);
 
        ret = drm_connector_attach_encoder(connector, encoder);
@@ -276,6 +296,7 @@ static int corebootdrm_probe(struct platform_device *pdev)
        int width, height, pitch;
        resource_size_t size;
        phys_addr_t address;
+       enum drm_panel_orientation orientation;
        struct resource *res, *mem = NULL;
        struct resource aperture;
        void __iomem *screen_base;
@@ -320,6 +341,7 @@ static int corebootdrm_probe(struct platform_device *pdev)
        address = corebootdrm_get_address_fb(dev, size, fb);
        if (!address)
                return -EINVAL;
+       orientation = corebootdrm_get_orientation_fb(dev, fb);
 
        sysfb->fb_mode = drm_sysfb_mode(width, height, 0, 0);
        sysfb->fb_format = format;
@@ -375,7 +397,7 @@ static int corebootdrm_probe(struct platform_device *pdev)
         * DRM mode setting and registration
         */
 
-       ret = corebootdrm_mode_config_init(cdev);
+       ret = corebootdrm_mode_config_init(cdev, orientation);
        if (ret)
                return ret;
 

diff --git a/include/linux/coreboot.h b/include/linux/coreboot.h
index 885da106fee3985c37b2ebe54d4c2e1bafdbb432..5d40ca7a1d8901c021ff7be1dd9424ddb6296cbf 100644 (file)
--- a/include/linux/coreboot.h
+++ b/include/linux/coreboot.h
@@ -47,6 +47,11 @@ struct lb_cbmem_entry {
        u32 id;
 };
 
+#define LB_FRAMEBUFFER_ORIENTATION_NORMAL      0
+#define LB_FRAMEBUFFER_ORIENTATION_BOTTOM_UP   1
+#define LB_FRAMEBUFFER_ORIENTATION_LEFT_UP     2
+#define LB_FRAMEBUFFER_ORIENTATION_RIGHT_UP    3
+
 /* Describes framebuffer setup by coreboot */
 struct lb_framebuffer {
        u32 tag;
@@ -65,6 +70,7 @@ struct lb_framebuffer {
        u8  blue_mask_size;
        u8  reserved_mask_pos;
        u8  reserved_mask_size;
+       u8  orientation;
 };
 
 /*
@@ -74,4 +80,11 @@ struct lb_framebuffer {
 #define LB_FRAMEBUFFER_HAS_LFB(__fb) \
        ((__fb)->size >= offsetofend(struct lb_framebuffer, reserved_mask_size))
 
+/*
+ * True if the coreboot-provided data is large enough to hold information
+ * on the display orientation. False otherwise.
+ */
+#define LB_FRAMEBUFFER_HAS_ORIENTATION(__fb) \
+       ((__fb)->size >= offsetofend(struct lb_framebuffer, orientation))
+
 #endif /* _LINUX_COREBOOT_H */