Remove auth_challenge field from or_handshake_state_t

We didn't need to record this value; it was already recorded
implicitly while computing cell digests for later examination in the
authenticate cells.

diff --git a/src/or/command.c b/src/or/command.c
index 3bd6dd7fd39fd1c84ebbe87c791c6590c53717df..7efd18fceced9eed2fa3d75e3eb31d2669ebc180 100644 (file)
--- a/src/or/command.c
+++ b/src/or/command.c
@@ -1043,9 +1043,6 @@ command_process_auth_challenge_cell(var_cell_t *cell, or_connection_t *conn)
   if (cell->payload_len < OR_AUTH_CHALLENGE_LEN + 2 + 2*n_types)
     ERR("It looks truncated");
 
-  memcpy(conn->handshake_state->auth_challenge, cell->payload,
-         OR_AUTH_CHALLENGE_LEN);
-
   /* Now see if there is an authentication type we can use */
   cp=cell->payload+OR_AUTH_CHALLENGE_LEN+2;
   for (i=0; i < n_types; ++i, cp += 2) {

diff --git a/src/or/or.h b/src/or/or.h
index aa12e31d67667bef07da01e3eb3d22442d5273d8..7268ae6f0c579e744aa7fd150160c058f17b4654 100644 (file)
--- a/src/or/or.h
+++ b/src/or/or.h
@@ -1162,9 +1162,6 @@ typedef struct or_handshake_state_t {
    * on this connection. */
   uint8_t authenticated_peer_id[DIGEST_LEN];
 
-  /** DOCDOC  */
-  uint8_t auth_challenge[OR_AUTH_CHALLENGE_LEN];
-
   /** Digests of the cells that we have sent or received as part of a V3
    * handshake.  Used for making and checking AUTHENTICATE cells.
    *