]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: rmi4 - propagate proper error code in F12 sensor tuning
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 5 May 2026 04:59:49 +0000 (21:59 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 12 Jun 2026 05:39:29 +0000 (22:39 -0700)
Propagate the actual error code returned by rmi_read() in
rmi_f12_read_sensor_tuning() instead of hardcoding -ENODEV.
Also, since rmi_read() returns 0 on success, use 'if (ret)'
instead of 'if (ret < 0)'.

Assisted-by: Gemini:gemini-3.1-pro
Link: https://patch.msgid.link/20260505045952.1570713-19-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_f12.c

index ea72d5ce80508f276d15954acc397dd0404e056e..bf8c4a0e10dede8b4dd09bf779ceea3a6dd2898e 100644 (file)
@@ -166,9 +166,9 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
                                                RMI_F12_QUERY_RESOLUTION);
                query_dpm_addr = fn->fd.query_base_addr + offset;
                ret = rmi_read(fn->rmi_dev, query_dpm_addr, buf);
-               if (ret < 0) {
+               if (ret) {
                        dev_err(&fn->dev, "Failed to read DPM value: %d\n", ret);
-                       return -ENODEV;
+                       return ret;
                }
                dpm_resolution = buf[0];