]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-116600: [Enum] fix global Flag repr (GH-116615)
authorEthan Furman <ethan@stoneleaf.us>
Mon, 11 Mar 2024 22:41:53 +0000 (15:41 -0700)
committerGitHub <noreply@github.com>
Mon, 11 Mar 2024 22:41:53 +0000 (15:41 -0700)
* and fix global flag repr

* Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Lib/enum.py
Lib/test/test_enum.py
Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst [new file with mode: 0644]

index bcf7aae949ffdbe9e6c287937cf1f731b885f4db..5c5e711f9b078f0aed3e91ac3da3319aadddb6ab 100644 (file)
@@ -1680,7 +1680,7 @@ def global_flag_repr(self):
     cls_name = self.__class__.__name__
     if self._name_ is None:
         return "%s.%s(%r)" % (module, cls_name, self._value_)
-    if _is_single_bit(self):
+    if _is_single_bit(self._value_):
         return '%s.%s' % (module, self._name_)
     if self._boundary_ is not FlagBoundary.KEEP:
         return '|'.join(['%s.%s' % (module, name) for name in self.name.split('|')])
index a83aca406cbd83ea398e8b0e4b51ef8cfb6b1ea5..6418d243db65ce2c0ba762afd21b62945ada1702 100644 (file)
@@ -4063,6 +4063,8 @@ class OldTestIntFlag(unittest.TestCase):
 
     @reraise_if_not_enum(NoName)
     def test_global_enum_str(self):
+        self.assertEqual(repr(NoName.ONE), 'test_enum.ONE')
+        self.assertEqual(repr(NoName(0)), 'test_enum.NoName(0)')
         self.assertEqual(str(NoName.ONE & NoName.TWO), 'NoName(0)')
         self.assertEqual(str(NoName(0)), 'NoName(0)')
 
diff --git a/Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst b/Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst
new file mode 100644 (file)
index 0000000..e9148ba
--- /dev/null
@@ -0,0 +1 @@
+Fix :func:`repr` for global :class:`~enum.Flag` members.