]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-netlink: drop 'flags' argument from sd_nfnl_nft_message_new_table()
authorYu Watanabe <watanabe.yu+github@gmail.com>
Sat, 3 Jul 2021 03:42:08 +0000 (12:42 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Sun, 29 Aug 2021 09:01:26 +0000 (18:01 +0900)
src/libsystemd/sd-netlink/netlink-message-nfnl.c
src/shared/firewall-util-nft.c
src/systemd/sd-netlink.h

index 03f70f606fc5aa4a407aee0c7f9ac176e297ba6d..ffcffb82f880c837a29d6da05492c5491b2a9899 100644 (file)
@@ -164,13 +164,12 @@ int sd_nfnl_nft_message_new_table(
                 sd_netlink *nfnl,
                 sd_netlink_message **ret,
                 int family,
-                const char *table,
-                uint16_t flags) {
+                const char *table) {
 
         _cleanup_(sd_netlink_message_unrefp) sd_netlink_message *m = NULL;
         int r;
 
-        r = nft_message_new(nfnl, &m, family, NFT_MSG_NEWTABLE, NLM_F_CREATE | flags);
+        r = nft_message_new(nfnl, &m, family, NFT_MSG_NEWTABLE, NLM_F_CREATE | NLM_F_EXCL | NLM_F_ACK);
         if (r < 0)
                 return r;
 
index e68978d777f1c9319644e0371b3e10a0f55579d2..d6beaf20d8a839f10554c897232285def08d8be4 100644 (file)
@@ -649,7 +649,7 @@ static int fw_nftables_init_family(sd_netlink *nfnl, int family) {
         msgcnt++;
         assert(msgcnt < NFT_INIT_MSGS);
         /* Set F_EXCL so table add fails if the table already exists. */
-        r = sd_nfnl_nft_message_new_table(nfnl, &batch[msgcnt], family, NFT_SYSTEMD_TABLE_NAME, NLM_F_EXCL | NLM_F_ACK);
+        r = sd_nfnl_nft_message_new_table(nfnl, &batch[msgcnt], family, NFT_SYSTEMD_TABLE_NAME);
         if (r < 0)
                 goto out_unref;
 
index c513d26071ff866b420370813f38037bebf8d385..c67ea87540192f1ff696e30d0f8c3e1f55663624 100644 (file)
@@ -229,7 +229,7 @@ int sd_nfnl_message_batch_end(sd_netlink *nfnl, sd_netlink_message **ret);
 int sd_nfnl_nft_message_del_table(sd_netlink *nfnl, sd_netlink_message **ret,
                                   int family, const char *table);
 int sd_nfnl_nft_message_new_table(sd_netlink *nfnl, sd_netlink_message **ret,
-                                  int family, const char *table, uint16_t nl_flags);
+                                  int family, const char *table);
 int sd_nfnl_nft_message_new_basechain(sd_netlink *nfnl, sd_netlink_message **ret,
                                       int family, const char *table, const char *chain,
                                       const char *type, uint8_t hook, int prio);