Coverity 1005134: fix minor memory leak on flowvar rule setup errors.

diff --git a/src/detect-flowvar.c b/src/detect-flowvar.c
index 31b0475b285b9ee3138540c1866a16332461cffe..7fc14921530ba491fea74c370cb25ef5fd537172 100644 (file)
--- a/src/detect-flowvar.c
+++ b/src/detect-flowvar.c
@@ -323,7 +323,7 @@ int DetectFlowvarPostMatchSetup(Signature *s, uint16_t idx) {
     fv->idx = idx;
 
     sm = SigMatchAlloc();
-    if (sm == NULL)
+    if (unlikely(sm == NULL))
         goto error;
 
     sm->type = DETECT_FLOWVAR_POSTMATCH;
@@ -332,6 +332,8 @@ int DetectFlowvarPostMatchSetup(Signature *s, uint16_t idx) {
     SigMatchAppendSMToList(s, sm, DETECT_SM_LIST_POSTMATCH);
     return 0;
 error:
+    if (fv != NULL)
+        DetectFlowvarDataFree(fv);
     return -1;
 }