]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
rules.d: Properly quote $env{MODALIAS}
authorRoshan Shariff <roshan.shariff@gmail.com>
Mon, 24 May 2021 07:30:38 +0000 (01:30 -0600)
committerLuca Boccassi <luca.boccassi@gmail.com>
Mon, 24 May 2021 17:40:01 +0000 (18:40 +0100)
 Add quotes around use of $env{MODALIAS} in rules.d/80-drivers.rules. The
 modalias can contain whitespace, for example when it is dynamically generated
 using device or vendor IDs.

rules.d/80-drivers.rules
test/fuzz/fuzz-udev-rules/80-drivers.rules

index 16fa5d8e3233b9026240e71e2453ec4c1e10a489..57d69b8232bd234d461a9708ddb0a6ca00254e19 100644 (file)
@@ -2,7 +2,7 @@
 
 ACTION!="add", GOTO="drivers_end"
 
-ENV{MODALIAS}=="?*", RUN{builtin}+="kmod load $env{MODALIAS}"
+ENV{MODALIAS}=="?*", RUN{builtin}+="kmod load '$env{MODALIAS}'"
 SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="SD", RUN{builtin}+="kmod load tifm_sd"
 SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="MS", RUN{builtin}+="kmod load tifm_ms"
 SUBSYSTEM=="memstick", RUN{builtin}+="kmod load ms_block mspro_block"
index 16fa5d8e3233b9026240e71e2453ec4c1e10a489..57d69b8232bd234d461a9708ddb0a6ca00254e19 100644 (file)
@@ -2,7 +2,7 @@
 
 ACTION!="add", GOTO="drivers_end"
 
-ENV{MODALIAS}=="?*", RUN{builtin}+="kmod load $env{MODALIAS}"
+ENV{MODALIAS}=="?*", RUN{builtin}+="kmod load '$env{MODALIAS}'"
 SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="SD", RUN{builtin}+="kmod load tifm_sd"
 SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="MS", RUN{builtin}+="kmod load tifm_ms"
 SUBSYSTEM=="memstick", RUN{builtin}+="kmod load ms_block mspro_block"