ASoC: Intel: Skylake: Fix mem leak in few functions

[ Upstream commit d5c65be34df73fa01ed05611aafb73b440d89e29 ]

The resources should be freed when function return error.

Signed-off-by: Kamil Duljas <kamil.duljas@gmail.com>
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20231116125150.1436-1-kamil.duljas@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index ac3dc8c63c260d681251ecb67ba90ca8389884cb..29a03ee3d7f734e34e3296973fdf53a15be64cd9 100644 (file)
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -252,8 +252,10 @@ static int skl_pcm_open(struct snd_pcm_substream *substream,
        snd_pcm_set_sync(substream);
 
        mconfig = skl_tplg_fe_get_cpr_module(dai, substream->stream);
-       if (!mconfig)
+       if (!mconfig) {
+               kfree(dma_params);
                return -EINVAL;
+       }
 
        skl_tplg_d0i3_get(skl, mconfig->d0i3_caps);
 

diff --git a/sound/soc/intel/skylake/skl-sst-ipc.c b/sound/soc/intel/skylake/skl-sst-ipc.c
index 7a425271b08b1686fc8310879a47e52be456da30..fd9624ad5f72b07e2a58e5ba220de2893aa7d301 100644 (file)
--- a/sound/soc/intel/skylake/skl-sst-ipc.c
+++ b/sound/soc/intel/skylake/skl-sst-ipc.c
@@ -1003,8 +1003,10 @@ int skl_ipc_get_large_config(struct sst_generic_ipc *ipc,
 
        reply.size = (reply.header >> 32) & IPC_DATA_OFFSET_SZ_MASK;
        buf = krealloc(reply.data, reply.size, GFP_KERNEL);
-       if (!buf)
+       if (!buf) {
+               kfree(reply.data);
                return -ENOMEM;
+       }
        *payload = buf;
        *bytes = reply.size;