]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Coverage: do not include test-rebind in coverage builds.
authorNick Mathewson <nickm@torproject.org>
Wed, 15 May 2019 18:58:46 +0000 (14:58 -0400)
committerNick Mathewson <nickm@torproject.org>
Thu, 23 May 2019 16:48:51 +0000 (12:48 -0400)
Because it invokes the Tor mainloop, it does unpredictable things to
test coverage of a lot of code that it doesn't actually test at
all.  (It is more an integration test than anything else.)

src/test/include.am

index 824089bc47cc5970947bfa8595ad5d8446c4c1b4..85f9c9f88039f705615b2c46fdf7d52bbfac665a 100644 (file)
@@ -32,8 +32,15 @@ endif
 
 if USEPYTHON
 TESTSCRIPTS += src/test/test_ntor.sh src/test/test_hs_ntor.sh src/test/test_bt.sh
+
+if COVERAGE_ENABLED
+# ...
+else
+# Only do this when coverage is not on, since it invokes lots of code
+# in a kind of unpredictable way.
 TESTSCRIPTS += src/test/test_rebind.sh
 endif
+endif
 
 TESTS += src/test/test src/test/test-slow src/test/test-memwipe \
        src/test/test_workqueue \