]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbd: Simplify samba_private_attr_name()
authorVolker Lendecke <vl@samba.org>
Wed, 27 Aug 2025 14:40:54 +0000 (16:40 +0200)
committerRalph Boehme <slow@samba.org>
Tue, 21 Oct 2025 17:33:29 +0000 (17:33 +0000)
We have strnequal for this

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/smb2_trans2.c

index d4ef3bb1c1f04aa37f271e1f9cf70b0c81e4c11b..9f60fa3e05bd34d1e8a1551ea927cacb5a78e02b 100644 (file)
@@ -168,16 +168,11 @@ bool samba_private_attr_name(const char *unix_ea_name)
        prohibited |= strequal(unix_ea_name, SAMBA_XATTR_REPARSE_ATTRIB);
        prohibited |= strequal(unix_ea_name, XATTR_NTACL_NAME);
        prohibited |= strequal(unix_ea_name, AFPINFO_EA_NETATALK);
+       prohibited |= strnequal(unix_ea_name,
+                               SAMBA_XATTR_DOSSTREAM_PREFIX,
+                               strlen(SAMBA_XATTR_DOSSTREAM_PREFIX));
 
-       if (prohibited) {
-               return true;
-       }
-
-       if (strncasecmp_m(unix_ea_name, SAMBA_XATTR_DOSSTREAM_PREFIX,
-                       strlen(SAMBA_XATTR_DOSSTREAM_PREFIX)) == 0) {
-               return true;
-       }
-       return false;
+       return prohibited;
 }
 
 /****************************************************************************