Issue #17901: fix TreeBuilder construction for an explicit element_factory=None

Based on report and patch by Aaron Oakley.

diff --git a/Lib/test/test_xml_etree.py b/Lib/test/test_xml_etree.py
index f3683f2d7e0825a0c79ff9c6e0026c7859325fca..7e0f25a460aab9cec18bad9f8be4e99e63786892 100644 (file)
--- a/Lib/test/test_xml_etree.py
+++ b/Lib/test/test_xml_etree.py
@@ -1762,6 +1762,12 @@ class TreeBuilderTest(unittest.TestCase):
         parser.feed(self.sample1)
         self.assertIsNone(parser.close())
 
+    def test_treebuilder_elementfactory_none(self):
+        parser = ET.XMLParser(target=ET.TreeBuilder(element_factory=None))
+        parser.feed(self.sample1)
+        e = parser.close()
+        self._check_sample1_element(e)
+
     def test_subclass(self):
         class MyTreeBuilder(ET.TreeBuilder):
             def foobar(self, x):

diff --git a/Misc/ACKS b/Misc/ACKS
index b47accffaa101c5108abe7e4a0ab5c922efe9522..4eb8ef6f6a725b71cd956be7496266485fdf01f2 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -887,6 +887,7 @@ John O'Connor
 Kevin O'Connor
 Tim O'Malley
 Zooko O'Whielacronx
+Aaron Oakley
 James Oakley
 Jon Oberheide
 Pascal Oberndoerfer

diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
index 9caef99ea6a6185d8030122ce51903400284301a..a568cd3b3051da40048e9cf06c8d391e1228b400 100644 (file)
--- a/Modules/_elementtree.c
+++ b/Modules/_elementtree.c
@@ -2381,7 +2381,7 @@ treebuilder_handle_start(TreeBuilderObject* self, PyObject* tag,
         self->data = NULL;
     }
 
-    if (self->element_factory) {
+    if (self->element_factory && self->element_factory != Py_None) {
         node = PyObject_CallFunction(self->element_factory, "OO", tag, attrib);
     } else {
         node = create_new_element(tag, attrib);