]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
firstboot: use parse_boolean_argument in one more place 41651/head
authorZbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
Thu, 16 Apr 2026 07:20:31 +0000 (09:20 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
Thu, 16 Apr 2026 14:55:17 +0000 (16:55 +0200)
This was pointed out in review.

src/firstboot/firstboot.c

index 22c6a42eb9701e373c72665e2732e684c11c8abd..ea4dd5f184038f3b3030ec88c1f9cda5d1096226 100644 (file)
@@ -41,7 +41,6 @@
 #include "options.h"
 #include "os-util.h"
 #include "parse-argument.h"
-#include "parse-util.h"
 #include "password-quality-util.h"
 #include "path-util.h"
 #include "plymouth-util.h"
@@ -1465,11 +1464,9 @@ static int parse_argv(int argc, char *argv[]) {
                         break;
 
                 OPTION_LONG("welcome", "BOOL", "Whether to show the welcome text"):
-                        r = parse_boolean(arg);
+                        r = parse_boolean_argument("--welcome=", arg, &arg_welcome);
                         if (r < 0)
-                                return log_error_errno(r, "Failed to parse --welcome= argument: %s", arg);
-
-                        arg_welcome = r;
+                                return r;
                         break;
 
                 OPTION_LONG("chrome", "BOOL",