Windows build targets have socklen_t definition in ws2tcpip.h but some

versions of ws2tcpip.h do not have the definition. It seems that when
the socklen_t definition is missing from ws2tcpip.h the definition for
INET_ADDRSTRLEN is also missing, and that when one definition is present
the other one also is available.

diff --git a/ares/config-win32.h b/ares/config-win32.h
index a4456320478ae9753a47c8c95dce04579ddee7ff..94ffe538908c363e098d2c3d9c9af70d2f829172 100644 (file)
--- a/ares/config-win32.h
+++ b/ares/config-win32.h
@@ -146,11 +146,6 @@
 #define ssize_t int
 #endif
 
-/* Define to 'int' if socklen_t is not an available 'typedefed' type */
-#ifndef HAVE_WS2TCPIP_H
-#define socklen_t int
-#endif
-
 /* ---------------------------------------------------------------- */
 /*                          STRUCT RELATED                          */
 /* ---------------------------------------------------------------- */

diff --git a/ares/setup.h b/ares/setup.h
index a20b8f1b7f64ca99ee7d51ec089aafb9dc2a84e8..29e5d0f1fcc0cdefc709639b358ca856aec0f489 100644 (file)
--- a/ares/setup.h
+++ b/ares/setup.h
@@ -97,10 +97,6 @@
 #define ssize_t int
 #endif
 
-#ifndef HAVE_WS2TCPIP_H
-#define socklen_t int
-#endif
-
 #endif /* HAVE_CONFIG_H */
 
 /*

diff --git a/ares/setup_once.h b/ares/setup_once.h
index d9b0f86eaa14550e28175308760b76270df1f900..20969d448c3a2007369474262af2d9c18e0865fd 100644 (file)
--- a/ares/setup_once.h
+++ b/ares/setup_once.h
@@ -91,6 +91,24 @@ struct timeval {
 #endif
 
 
+/*
+ * Windows build targets have socklen_t definition in
+ * ws2tcpip.h but some versions of ws2tcpip.h do not
+ * have the definition. It seems that when the socklen_t
+ * definition is missing from ws2tcpip.h the definition
+ * for INET_ADDRSTRLEN is also missing, and that when one
+ * definition is present the other one also is available.
+ */
+
+#if defined(WIN32) && !defined(HAVE_SOCKLEN_T)
+#  if ( defined(_MSC_VER) && !defined(INET_ADDRSTRLEN) ) || \
+      (!defined(_MSC_VER) && !defined(HAVE_WS2TCPIP_H) )
+#    define socklen_t int
+#    define HAVE_SOCKLEN_T
+#  endif
+#endif
+
+
 #if defined(__minix)
 /* Minix doesn't support recv on TCP sockets */
 #define sread(x,y,z) (ssize_t)read((RECV_TYPE_ARG1)(x), \

diff --git a/lib/config-win32.h b/lib/config-win32.h
index 0bc736431fcc72ab3c9fb90027fd500cbb63ae79..6102f9386a95ea2222cb4a80fefb78ee044731f2 100644 (file)
--- a/lib/config-win32.h
+++ b/lib/config-win32.h
@@ -290,11 +290,6 @@
 #define _SSIZE_T_DEFINED
 #endif
 
-/* Define to 'int' if socklen_t is not an available 'typedefed' type */
-#if defined(_MSC_VER) && (_MSC_VER <= 1400)
-#define socklen_t int
-#endif
-
 /* ---------------------------------------------------------------- */
 /*                            TYPE SIZES                            */
 /* ---------------------------------------------------------------- */

diff --git a/lib/config-win32ce.h b/lib/config-win32ce.h
index e7d157202a7755a5237404351a77877d764be12c..4d40160797f49a3c090e2404d40e882f448c7cf7 100644 (file)
--- a/lib/config-win32ce.h
+++ b/lib/config-win32ce.h
@@ -273,11 +273,6 @@
 #define ssize_t int
 #endif
 
-/* Define to 'int' if socklen_t is not an available 'typedefed' type */
-#ifndef HAVE_WS2TCPIP_H
-#define socklen_t int
-#endif
-
 /* ---------------------------------------------------------------- */
 /*                            TYPE SIZES                            */
 /* ---------------------------------------------------------------- */

diff --git a/lib/setup_once.h b/lib/setup_once.h
index ba564120a06ef21c4f21527fbedb5f5529d71346..83ee95cf4cd21d1a045ec10a65312af2d135408f 100644 (file)
--- a/lib/setup_once.h
+++ b/lib/setup_once.h
@@ -98,6 +98,24 @@ struct timeval {
 #endif
 
 
+/*
+ * Windows build targets have socklen_t definition in
+ * ws2tcpip.h but some versions of ws2tcpip.h do not
+ * have the definition. It seems that when the socklen_t
+ * definition is missing from ws2tcpip.h the definition
+ * for INET_ADDRSTRLEN is also missing, and that when one
+ * definition is present the other one also is available.
+ */
+
+#if defined(WIN32) && !defined(HAVE_SOCKLEN_T)
+#  if ( defined(_MSC_VER) && !defined(INET_ADDRSTRLEN) ) || \
+      (!defined(_MSC_VER) && !defined(HAVE_WS2TCPIP_H) )
+#    define socklen_t int
+#    define HAVE_SOCKLEN_T
+#  endif
+#endif
+
+
 #if defined(__minix)
 /* Minix doesn't support recv on TCP sockets */
 #define sread(x,y,z) (ssize_t)read((RECV_TYPE_ARG1)(x), \

diff --git a/src/config-win32.h b/src/config-win32.h
index 3884970784a3653ccc900a8ccc2a92d00e5c8a01..f3fb6201c3bca89e6dd3a823dbc4faf17bec9546 100644 (file)
--- a/src/config-win32.h
+++ b/src/config-win32.h
@@ -149,11 +149,6 @@
 #define ssize_t int
 #endif
 
-/* Define to 'int' if socklen_t is not an available 'typedefed' type */
-#ifndef HAVE_WS2TCPIP_H
-#define socklen_t int
-#endif
-
 /* ---------------------------------------------------------------- */
 /*                          STRUCT RELATED                          */
 /* ---------------------------------------------------------------- */