Fix some leaks found by valgrind.

  - leaking the 'data' pref value for a log handler.
  - leaking an rpc message response if the caller doesn't want it.
  - leaking username/password for every guestOp

diff --git a/open-vm-tools/lib/rpcChannel/rpcChannel.c b/open-vm-tools/lib/rpcChannel/rpcChannel.c
index 39cd63cea6b1eb6514448bc30bfc22f4a8f7c4c1..9eb7f31098e77be27876c6f076e901e8332a93ed 100644 (file)
--- a/open-vm-tools/lib/rpcChannel/rpcChannel.c
+++ b/open-vm-tools/lib/rpcChannel/rpcChannel.c
@@ -896,6 +896,8 @@ done:
 
    if (result != NULL) {
       *result = res;
+   } else {
+      free(res);
    }
    if (resultLen != NULL) {
       *resultLen = resLen;

diff --git a/open-vm-tools/libvmtools/vmtoolsLog.c b/open-vm-tools/libvmtools/vmtoolsLog.c
index 381797ac430792b124be0efc90017d2cbfc2952c..647ec48c1360cbbb02ce3385c974d8197435ab53 100644 (file)
--- a/open-vm-tools/libvmtools/vmtoolsLog.c
+++ b/open-vm-tools/libvmtools/vmtoolsLog.c
@@ -875,6 +875,7 @@ VMToolsConfigLogDomain(const gchar *domain,
 exit:
    g_free(handler);
    g_free(level);
+   g_free(confData);
 }
 
 

diff --git a/open-vm-tools/services/plugins/vix/vixTools.c b/open-vm-tools/services/plugins/vix/vixTools.c
index 4c0995b12aae619e1f1ad096490d5a00e3ae2094..aa8538a30515f0dd845af7df77a5f802daa15575 100644 (file)
--- a/open-vm-tools/services/plugins/vix/vixTools.c
+++ b/open-vm-tools/services/plugins/vix/vixTools.c
@@ -11327,8 +11327,8 @@ GuestAuthPasswordAuthenticateImpersonate(
 {
 #if SUPPORT_VGAUTH
    VixError err;
-   char *username;
-   char *password;
+   char *username = NULL;
+   char *password = NULL;
    VGAuthContext *ctx = NULL;
    VGAuthError vgErr;
    VGAuthUserHandle *newHandle = NULL;
@@ -11377,6 +11377,8 @@ GuestAuthPasswordAuthenticateImpersonate(
    err = VIX_OK;
 
 done:
+   free(username);
+   Util_ZeroFreeString(password);
 
    return err;
 #else