]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: arm_scmi: Skip RAW initialization on failure
authorCristian Marussi <cristian.marussi@arm.com>
Tue, 14 Oct 2025 11:53:46 +0000 (12:53 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Wed, 15 Oct 2025 14:28:01 +0000 (15:28 +0100)
Avoid attempting to initialize RAW mode when the debug subsystem itself
has failed to initialize, since doing so is pointless and emits
misleading error messages.

Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Message-Id: <20251014115346.2391418-3-cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/driver.c

index 1cd15412024cd46fab11cda9a01ab54d01504e98..eb46694cb14bc492bfffdefae7f4377adbfc612d 100644 (file)
@@ -3028,9 +3028,6 @@ static int scmi_debugfs_raw_mode_setup(struct scmi_info *info)
        u8 channels[SCMI_MAX_CHANNELS] = {};
        DECLARE_BITMAP(protos, SCMI_MAX_CHANNELS) = {};
 
-       if (!info->dbg)
-               return -EINVAL;
-
        /* Enumerate all channels to collect their ids */
        idr_for_each_entry(&info->tx_idr, cinfo, id) {
                /*
@@ -3202,7 +3199,7 @@ static int scmi_probe(struct platform_device *pdev)
                if (!info->dbg)
                        dev_warn(dev, "Failed to setup SCMI debugfs.\n");
 
-               if (IS_ENABLED(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT)) {
+               if (info->dbg && IS_ENABLED(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT)) {
                        ret = scmi_debugfs_raw_mode_setup(info);
                        if (!coex) {
                                if (ret)