]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-44558: Make the implementation consistency of operator.indexOf (GH-27012)
authorDong-hee Na <donghee.na@python.org>
Mon, 5 Jul 2021 09:04:36 +0000 (18:04 +0900)
committerGitHub <noreply@github.com>
Mon, 5 Jul 2021 09:04:36 +0000 (18:04 +0900)
Lib/operator.py
Lib/test/test_operator.py
Misc/NEWS.d/next/Library/2021-07-04-21-16-53.bpo-44558.cm7Slv.rst [new file with mode: 0644]

index fb58851fa6ef6732de021740cf16f79c51bb85a2..6782703476edee4d3b0605efc3e47db834d5f6c9 100644 (file)
@@ -173,7 +173,7 @@ def getitem(a, b):
 def indexOf(a, b):
     "Return the first index of b in a."
     for i, j in enumerate(a):
-        if j == b:
+        if j is b or j == b:
             return i
     else:
         raise ValueError('sequence.index(x): x not in sequence')
index 1ecae85f62f2c9aa40d685038b8b5167233a5660..d50306b7f1ecb8fba160cb953f5b2e463fd6c462 100644 (file)
@@ -188,6 +188,9 @@ class OperatorTestCase:
         self.assertRaises(ZeroDivisionError, operator.indexOf, BadIterable(), 1)
         self.assertEqual(operator.indexOf([4, 3, 2, 1], 3), 1)
         self.assertRaises(ValueError, operator.indexOf, [4, 3, 2, 1], 0)
+        nan = float("nan")
+        self.assertEqual(operator.indexOf([nan, nan, 21], nan), 0)
+        self.assertEqual(operator.indexOf([{}, 1, {}, 2], {}), 0)
 
     def test_invert(self):
         operator = self.module
diff --git a/Misc/NEWS.d/next/Library/2021-07-04-21-16-53.bpo-44558.cm7Slv.rst b/Misc/NEWS.d/next/Library/2021-07-04-21-16-53.bpo-44558.cm7Slv.rst
new file mode 100644 (file)
index 0000000..647a704
--- /dev/null
@@ -0,0 +1,2 @@
+Make the implementation consistency of :func:`~operator.indexOf` between
+C and Python versions. Patch by Dong-hee Na.