]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mailbox: mtk-gpueb: Add missing 'static' to mailbox ops struct
authorNicolas Frattaroli <nicolas.frattaroli@collabora.com>
Mon, 13 Oct 2025 08:09:01 +0000 (10:09 +0200)
committerJassi Brar <jassisinghbrar@gmail.com>
Fri, 28 Nov 2025 15:31:53 +0000 (09:31 -0600)
mtk_gpueb_mbox_ops should be declared static. However, due to its const
nature, this specifier was missed, as it compiled fine without it and
with no warning by the compiler.

arc-linux-gcc (GCC) 12.5.0 doesn't seem to like it however, so add the
static to fix that.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510100629.3nGvrhEU-lkp@intel.com/
Fixes: dbca0eabb821 ("mailbox: add MediaTek GPUEB IPI mailbox")
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/mtk-gpueb-mailbox.c

index 925bcf21f650decdb6abd4c07e61b72bc6c3c94e..f6d2beccd91b17855b51c96efc2d65173ef3e399 100644 (file)
@@ -200,7 +200,7 @@ static bool mtk_gpueb_mbox_last_tx_done(struct mbox_chan *chan)
        return !(readl(ch->ebm->mbox_ctl + GPUEB_MBOX_CTL_TX_STS) & BIT(ch->num));
 }
 
-const struct mbox_chan_ops mtk_gpueb_mbox_ops = {
+static const struct mbox_chan_ops mtk_gpueb_mbox_ops = {
        .send_data = mtk_gpueb_mbox_send_data,
        .startup = mtk_gpueb_mbox_startup,
        .shutdown = mtk_gpueb_mbox_shutdown,